Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 10MB the default stack size for additional threads #9159

Merged
merged 1 commit into from May 20, 2015
Merged

Make 10MB the default stack size for additional threads #9159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions FWCore/Framework/bin/cmsRun.cpp
View file
Open in desktop
Expand Up @@ -54,6 +54,7 @@ static char const* const kHelpOpt = "help";
static char const* const kHelpCommandOpt = "help,h";
static char const* const kStrictOpt = "strict";

constexpr unsigned int kDefaultSizeOfStackForThreadsInKB = 10*1024; //10MB
// -----------------------------------------------
namespace {
class EventProcessorWithSentry {
Expand Down Expand Up @@ -235,7 +236,7 @@ int main(int argc, char* argv[]) {
if(vm.count(kNumberOfThreadsOpt)) {
setNThreadsOnCommandLine=true;
unsigned int nThreads = vm[kNumberOfThreadsOpt].as<unsigned int>();
unsigned int stackSize=0;
unsigned int stackSize=kDefaultSizeOfStackForThreadsInKB;
if(vm.count(kSizeOfStackForThreadOpt)) {
stackSize=vm[kSizeOfStackForThreadOpt].as<unsigned int>();
}
Expand Down Expand Up @@ -295,8 +296,8 @@ int main(int argc, char* argv[]) {
auto const& ops = pset->getUntrackedParameterSet("options");
if(ops.existsAs<unsigned int>("numberOfThreads",false)) {
unsigned int nThreads = ops.getUntrackedParameter<unsigned int>("numberOfThreads");
unsigned int stackSize=0;
if(ops.existsAs<unsigned int>("sizeOfStackForThreadsInKB",0)) {
unsigned int stackSize=kDefaultSizeOfStackForThreadsInKB;
if(ops.existsAs<unsigned int>("sizeOfStackForThreadsInKB",false)) {
stackSize = ops.getUntrackedParameter<unsigned int>("sizeOfStackForThreadsInKB");
}
const auto nThreadsUsed = setNThreads(nThreads,stackSize,tsiPtr);
Expand Down