Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to compute signed IP wrt tau direction #9160

Merged
merged 5 commits into from Jul 15, 2015

Conversation

andrewj314
Copy link
Contributor

…and also store 3D IP's

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_5_X.

Added functionality to compute signed IP wrt tau direction

It involves the following packages:

DataFormats/TauReco
RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 6, 2015

+1

For #9160 d776416

Adding calculation of signed interaction point with respect to the tau direction. This PR should not alter other monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-02-2300 show no significant differences, as expected. The error that Jenkins notes above is a failure of unit tests for #9758, the 76X version of this PR. The error doesn't seem to be related to this PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants