Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our tests for the new frozen menus, and move to the 50ns table with correct prescales #9161

Merged
merged 8 commits into from May 21, 2015

Conversation

perrotta
Copy link
Contributor

Fix cmsDriver.csh for the new frozen menus, and move to the 50ns table with correct prescales

This Pull Request does nothing, in fact: it simply adds a missing internat TSG test for the new frozen tables, and has the correct version number for the 50ns tables (HLT prescales were actually modified in those tables, but those values are not dumped in CMSSW: therefore the corresponding files in the release only differ for the version number of the HLT table)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_5_X.

Fix our tests for the new frozen menus, and move to the 50ns table with correct prescales

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor Author

+1

@perrotta
Copy link
Contributor Author

please test

@Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

ie, the corresponding symbolic GT definitions...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 21, 2015
Fix our tests for the new frozen menus, and move to the 50ns table with correct prescales
@cmsbuild cmsbuild merged commit 515ea0b into cms-sw:CMSSW_7_5_X May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants