New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for phi in ebdetid creation #9172
fix for phi in ebdetid creation #9172
Conversation
A new Pull Request was created by @argiro for CMSSW_7_5_X. fix for phi in ebdetid creation It involves the following packages: RecoLocalCalo/EcalRecProducers @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Bug fix for a PromptReco crash. It should not change monitored quantities. The fix is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-20-1100 show no significant differences, as expected. A test of the fix in 742_patch1 verified that the crash no longer occurs. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
…-75X fix for phi in ebdetid creation
fixes problem in PromptReco reported in
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1355.html