New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare members of InputTag as thread safe #9180
Declare members of InputTag as thread safe #9180
Conversation
The static analyzer was complaining about the mutable members in InputTag. However, these members are thread safe since they are protected by index_. Added CMS' thread safe attributes to silence the false positive.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. Declare members of InputTag as thread safe It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
Declare members of InputTag as thread safe
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
The static analyzer was complaining about the mutable members in InputTag. However, these members are thread safe since they are protected by index_. Added CMS' thread safe attributes to silence the false positive.