Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform VertexAssociatorByTracks to EDProduct style #9223

Merged
merged 5 commits into from May 26, 2015

Conversation

makortel
Copy link
Contributor

This PR transforms VertexAssociatorByTracks from ESProduct to EDProduct (following how TrackToTrackingParticleAssociators are organized). I'm planning to introduce new vertex associator(s) (separating it out from vertex validation code), and to use them in vertex and track validation code.

On the same go, the definitions of reco::VertexBaseRef, reco::VertexSimToRecoCollection, and VertexRecoToSimCollection were moved to more proper places (the first one pulls quite a lot of packages...).

Tested in CMSSW_7_5_X_2015-05-12-2300. No changes expected in results.

@rovere @VinInn

Following what was done for Track associators. I'm planning to add
other vertex associators and start to use them in track and vertex
validation, and therefore wanted to "modernize" the existing vertex
associator.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Transform VertexAssociatorByTracks to EDProduct style

It involves the following packages:

DataFormats/VertexReco
SimDataFormats/Associations
SimTracker/Records
SimTracker/TrackHistory
SimTracker/VertexAssociation
SimTracker/VertexAssociatorESProducer
Validation/RecoB

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@jlagram, @imarches, @threus, @acaudron, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @appeltel, @cnuttens, @prolay, @ferencek, @cerati, @venturia, @pvmulder, @dgulhan, @LBeck this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 22, 2015

+1
only slightly touching DQM

@civanch
Copy link
Contributor

civanch commented May 22, 2015

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants