New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform VertexAssociatorByTracks to EDProduct style #9223
Transform VertexAssociatorByTracks to EDProduct style #9223
Conversation
Following what was done for Track associators. I'm planning to add other vertex associators and start to use them in track and vertex validation, and therefore wanted to "modernize" the existing vertex associator.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Transform VertexAssociatorByTracks to EDProduct style It involves the following packages: DataFormats/VertexReco @civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks. |
+1 |
please test |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
Transform VertexAssociatorByTracks to EDProduct style
This PR transforms VertexAssociatorByTracks from ESProduct to EDProduct (following how TrackToTrackingParticleAssociators are organized). I'm planning to introduce new vertex associator(s) (separating it out from vertex validation code), and to use them in vertex and track validation code.
On the same go, the definitions of
reco::VertexBaseRef
,reco::VertexSimToRecoCollection
, andVertexRecoToSimCollection
were moved to more proper places (the first one pulls quite a lot of packages...).Tested in CMSSW_7_5_X_2015-05-12-2300. No changes expected in results.
@rovere @VinInn