Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF1::GetParErrors() const returns const Double_t * in ROOT 6.04.00 #9230

Merged
merged 1 commit into from May 22, 2015
Merged

TF1::GetParErrors() const returns const Double_t * in ROOT 6.04.00 #9230

merged 1 commit into from May 22, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 22, 2015

Update in ROOT 6.04.00 changed return type of TF1::GetParErrors() const
to be const.

See ROOT commit: 0539de6de4bb7aba2160da0195296aa0d94209ce

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

TF1::GetParErrors() const returns const Double_t * in ROOT 6.04.00
cd5a10d 
Update in ROOT 6.04.00 changed return type of TF1::GetParErrors() const
to be const.

See ROOT commit: 0539de6de4bb7aba2160da0195296aa0d94209ce

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 22, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

TF1::GetParErrors() const returns const Double_t * in ROOT 6.04.00

It involves the following packages:

DQMServices/ClientConfig
MuonAnalysis/MomentumScaleCalibration

@nclopezo, @danduggan, @monttj, @cmsbuild, @deguio, @vadler can you please review it and eventually sign? Thanks.
@bellan, @frmeier, @barvic, @mmusich, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 22, 2015

please test

@deguio
Copy link
Contributor

deguio commented May 22, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

davidlange6 added a commit that referenced this pull request May 22, 2015
@davidlange6
Merge pull request #9230 from davidlt/root604-tf1-GetParErrors-const
03989e0 
TF1::GetParErrors() const returns const Double_t * in ROOT 6.04.00
@davidlange6 davidlange6 merged commit 03989e0 into cms-sw:CMSSW_7_5_X May 22, 2015
@cmsbuild
Copy link
Contributor

+1
Tested at: cd5a10d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9230/4949/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9230/4949/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending dqm-approved orp-pending pending-signatures tests-started
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @deguio @davidlange6