Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for 'branchListIndexes' branch before adding to TTreeCache #9231

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 22, 2015

The following is causing a crash on 4.6 workflow with ROOT 6.04.00.

Particular input file example:

/store/data/Run2010A/MinimumBias/RAW-RECO/v6/000/138/923/142C82F8-4285-DF11-B26D-00E081791865.root

This input file does not contain 'branchListIndexes' branch.

For more details, look at ROOT-7015 and ROOT commit:
5fc68e7a161370008aa97cac9c5cdda6ad326ea5

..this avoids the situation where the user could ask for a
branch to be added to a TTree's cache and have the
call silently have no effect.

ROOT 6.04.00 will trigger error exception if input file does not
have required branch.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following is causing a crash on 4.6 workflow with ROOT 6.04.00.

Particular input file example:

    /store/data/Run2010A/MinimumBias/RAW-RECO/v6/000/138/923/142C82F8-4285-DF11-B26D-00E081791865.root

This input file does not contain 'branchListIndexes' branch.

For more details, look at ROOT-7015 and ROOT commit:
5fc68e7a161370008aa97cac9c5cdda6ad326ea5

    ..this avoids the situation where the user could ask for a
    branch to be added to a TTree's cache and have the
    call silently have no effect.

ROOT 6.04.00 will trigger error exception if input file does not
have required branch.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Check for 'branchListIndexes' branch before adding to TTreeCache

It involves the following packages:

IOPool/Input

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants