Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod highest values #9242

Merged
merged 8 commits into from Jun 6, 2015
Merged

Conversation

rrabadan
Copy link
Contributor

The possibility to produce a sorted list of the N modules with the largest digi, cluster, off track cluster occupancy when the corresponding tracker maps are produced is added

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rrabadan (Raul Rabadan) for CMSSW_7_5_X.

Mod highest values

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@venturia
Copy link
Contributor

@rrabadan, @threus,
I know it is painful and it sounds like a tax to be payed only by honest citizens, but could you profit of this pull request and add in the README.md file of this package the documentation about the instructions on how to use and configure the plugin SiStripOfflineDQM ? It would be very useful.

                                      ciao

                              Andrea

On May 23, 2015, at 3:21 , cmsbuild <notifications@github.commailto:notifications@github.com>
wrote:

A new Pull Request was created by @rrabadanhttps://github.com/rrabadan (Raul Rabadan) for CMSSW_7_5_X.

Mod highest values

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuildhttps://github.com/cmsbuild, @dandugganhttps://github.com/danduggan, @nclopezohttps://github.com/nclopezo, @deguiohttps://github.com/deguio can you please review it and eventually sign? Thanks.
@threushttps://github.com/threus, @venturiahttps://github.com/venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezohttps://github.com/nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9242#issuecomment-104810723.

@cmsbuild
Copy link
Contributor

-1
@rrabadan This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9242/7823/git-merge-result

@rrabadan
Copy link
Contributor Author

Conflicts fixed.

On May 24, 2015, at 10:11, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

-1
@rrabadanhttps://github.com/rrabadan This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9242/7823/git-merge-result


Reply to this email directly or view it on GitHubhttps://github.com//pull/9242#issuecomment-105023322.

@threus
Copy link
Contributor

threus commented Jun 3, 2015

pretty ping..

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 6, 2015
@cmsbuild cmsbuild merged commit bb999a1 into cms-sw:CMSSW_7_5_X Jun 6, 2015
rrabadan added a commit to rrabadan/cmssw that referenced this pull request Jul 16, 2015
cmsbuild added a commit that referenced this pull request Aug 11, 2015
backport of #9242: Add the list of the N modules with the largest occupancy from tracker maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants