New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate function productHistoryRegistryUpdate() #9249
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Remove duplicate function productHistoryRegistryUpdate() It involves the following packages: DQMServices/FwkIO @cmsbuild, @danduggan, @Dr15Jones, @deguio, @nclopezo can you please review it and eventually sign? Thanks. |
Please test |
+1 |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
Remove duplicate function productHistoryRegistryUpdate()
I noticed that class InputSource had two different member functions that were identical except for the function name. There is no good reason for this, and it may be confusing. So, I removed productHistoryRegistryUpdate(), which was called in fewer places than productHistoryRegistryForUpdate(), and replaced its usage. The function need not be public.
This PR is fairly trivial.
If the DQM L2 does not respond in a timely manner, I suggest that the DQM signature be bypassed, as there are no functional changes to DQM.