Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function productHistoryRegistryUpdate() #9249

Merged
merged 1 commit into from May 25, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 23, 2015

I noticed that class InputSource had two different member functions that were identical except for the function name. There is no good reason for this, and it may be confusing. So, I removed productHistoryRegistryUpdate(), which was called in fewer places than productHistoryRegistryForUpdate(), and replaced its usage. The function need not be public.
This PR is fairly trivial.
If the DQM L2 does not respond in a timely manner, I suggest that the DQM signature be bypassed, as there are no functional changes to DQM.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Remove duplicate function productHistoryRegistryUpdate()

It involves the following packages:

DQMServices/FwkIO
FWCore/Framework
IOPool/Input
IOPool/Streamer

@cmsbuild, @danduggan, @Dr15Jones, @deguio, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented May 25, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants