Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call common Stage1 customs when 50ns and LowPU customization versions… #9264

Merged

Conversation

mulhearn
Copy link
Contributor

… are called

This is intended to fix remaining problem identified in PR #9216

Not tested yet, checking now.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_7_5_X.

call common Stage1 customs when 50ns and LowPU customization versions

It involves the following packages:

L1Trigger/L1TCommon

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor Author

please test

@mulhearn
Copy link
Contributor Author

Seems to fix failed workflow... more testing now...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 26, 2015
…ustoms

call common Stage1 customs when 50ns and LowPU customization versions…
@cmsbuild cmsbuild merged commit a8ca939 into cms-sw:CMSSW_7_5_X May 26, 2015
@mulhearn mulhearn deleted the l1t-bugfix-50ns-lowPU-customs branch October 18, 2015 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants