New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended the convertToUnscheduled unit test for unused Paths #9266
Extended the convertToUnscheduled unit test for unused Paths #9266
Conversation
Extended the unit test for convertToUnscheduled to test that Paths not on the Schedule are handled properly. They are handled properly such that the Path is removed from the Process and all modules only on that Path are also removed.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. Extended the convertToUnscheduled unit test for unused Paths It involves the following packages: FWCore/ParameterSet @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
…usedPathInSchedule Extended the convertToUnscheduled unit test for unused Paths
Extended the unit test for convertToUnscheduled to test that Paths
not on the Schedule are handled properly. They are handled properly
such that the Path is removed from the Process and all modules only
on that Path are also removed.