Fix use-after-free in DynamicTruncation::preliminaryFit

[davidlt]

On the first iteration we used end() of STL container. end() returns
a pointer after the last element in container. In this case, we were
starting iteration from the last removed TrackingRecHit.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Fix use-after-free in DynamicTruncation::preliminaryFit

It involves the following packages:

RecoMuon/GlobalTrackingTools

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @bellan, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: af475f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9282/5036/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9282/5036/summary.html

[slava77]

@davidlt David, please make a PR for 74X as well.
Thank you.

[slava77]

+1

for #9282 af475f9

• jenkins tests pass and comparisons with the baseline show no difference

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1