Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AutoLibraryLoader (FWLite), which is misnamed #9305

Merged
merged 1 commit into from May 31, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 27, 2015

The class AutoLibraryLoader, in FWLite, is badly misnamed, because, with the use of rootmap files, this class no longer loads any libraries. A new class, FWLiteEnabler, replaces AutoLibraryLoader.
The AutoLibraryLoader class is kept for now just in case any private user code is using it.
FWLiteEnabler::enable() replaces AutoLibraryLoader::enable().
Any remaining use of AutoLibraryLoader::enable() will work for now, but a warning message will be given.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Rename AutoLibraryLoader (FWLite), which is misnamed

It involves the following packages:

Alignment/OfflineValidation
Alignment/SurveyAnalysis
CalibMuon/RPCCalibration
Calibration/EcalAlCaRecoProducers
CommonTools/CandAlgos
CommonTools/ParticleFlow
CommonTools/RecoAlgos
CondFormats/JetMETObjects
CondTools/Utilities
Configuration/EventContent
DQM/SiStripHistoricInfoClient
DQMOffline/CalibCalo
DQMServices/Diagnostic
DataFormats/FWLite
DataFormats/ParticleFlowReco
ElectroWeakAnalysis/ZMuMu
FWCore/FWLite
FWCore/ROOTTests
FWCore/TFWLiteSelector
FWCore/Utilities
FastSimulation/MaterialEffects
FastSimulation/PileUpProducer
Fireworks/Core
GeneratorInterface/Pythia6Interface
HLTrigger/Timer
HLTrigger/Tools
HeavyIonsAnalysis/Configuration
IOMC/EventVertexGenerators
JetMETCorrections/MinBias
L1Trigger/GlobalMuonTrigger
MuonAnalysis/MomentumScaleCalibration
PerfTools/EdmEvent
PhysicsTools/FWLite
PhysicsTools/HepMCCandAlgos
PhysicsTools/Heppy
PhysicsTools/ParallelAnalysis
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/PythonAnalysis
PhysicsTools/RecoAlgos
PhysicsTools/SelectorUtils
PhysicsTools/UtilAlgos
RecoBTag/PerformanceDB
RecoEcal/EgammaCoreTools
RecoJets/Configuration
RecoJets/JetProducers
RecoMuon/MuonIdentification
RecoParticleFlow/PFClusterProducer
RecoTracker/FinalTrackSelectors
RecoTracker/TrackProducer
SUSYBSMAnalysis/HSCP
SimG4CMS/HcalTestBeam
TopQuarkAnalysis/Examples
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopJetCombination
TrackingTools/TrackAssociator
Validation/CaloTowers
Validation/EcalHits
Validation/GlobalDigis
Validation/GlobalHits
Validation/GlobalRecHits
Validation/HcalHits
Validation/MuonIdentification
Validation/RecoVertex
Validation/Tools
Validation/TrackerHits

@diguida, @lveldere, @cerminar, @Martin-Grunewald, @covarell, @bendavid, @perrotta, @civanch, @cmsbuild, @fwyzard, @davidlange6, @vciulli, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @ggovi, @vadler, @mmusich, @mulhearn, @ssekmen, @nclopezo, @danduggan, @thuer, @monttj, @alja, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @yslai, @abbiendi, @TaiSakuma, @argiro, @Martin-Grunewald, @tlampen, @ahinzmann, @threus, @venturia, @mmarionncern, @kreczko, @battibass, @makortel, @acaudron, @jhgoh, @lgray, @jdolen, @ferencek, @cerati, @trocino, @yetkinyilmaz, @Sam-Harper, @barvic, @GiacomoSguazzoni, @frmeier, @rovere, @VinInn, @bellan, @nhanvtran, @schoef, @mschrode, @mmusich, @dgulhan, @apfeiffer1, @mkirsano, @mandrenguyen, @imarches, @wddgit, @appeltel, @alja, @gpetruc, @matt-komm, @mariadalfonso, @rociovilar, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment