New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AutoLibraryLoader (FWLite), which is misnamed #9305
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Rename AutoLibraryLoader (FWLite), which is misnamed It involves the following packages: Alignment/OfflineValidation @diguida, @lveldere, @cerminar, @Martin-Grunewald, @covarell, @bendavid, @perrotta, @civanch, @cmsbuild, @fwyzard, @davidlange6, @vciulli, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @ggovi, @vadler, @mmusich, @mulhearn, @ssekmen, @nclopezo, @danduggan, @thuer, @monttj, @alja, @franzoni can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Rename AutoLibraryLoader (FWLite), which is misnamed
The class AutoLibraryLoader, in FWLite, is badly misnamed, because, with the use of rootmap files, this class no longer loads any libraries. A new class, FWLiteEnabler, replaces AutoLibraryLoader.
The AutoLibraryLoader class is kept for now just in case any private user code is using it.
FWLiteEnabler::enable() replaces AutoLibraryLoader::enable().
Any remaining use of AutoLibraryLoader::enable() will work for now, but a warning message will be given.