Avoid calls to mallopt() if ASan is active #9308
Conversation
`mallopt()` calls are not valid on ASan builds, avoid them. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_5_X. Avoid calls to mallopt() if ASan is active It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
|
I'm waiting to request testing until we have a working IB |
| @@ -162,6 +162,7 @@ namespace edm | |||
| error_message_.clear(); | |||
| changed_ = false; | |||
|
|
|||
| #ifndef __SANITIZE_ADDRESS__ | |||
There was a problem hiding this comment.
Is address sanitizing a function of the operating system or of how the operating system is configured? Basically I'm asking if this is really a compile time switch or should really be a run time one.
There was a problem hiding this comment.
Compile time + run-time library. The main executable (cmsRun) is statically linked to ASan run-time, which initializes required structures and brings all symbols. At compile time it adds and replaces functions calls with special functions in ASan run-time which do all accounting.
|
There is nothing to test here. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Avoid calls to mallopt() if ASan is active
mallopt()calls are not valid on ASan builds, avoid them.Without this I keep getting
ERROR:from CMSSW and exact same string fragment is used in ASan reports. This cleans the noise created by not workingmallopt()calls on ASan builds.Makes grepping easier.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch