Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply DT vdrift correction (that accounts for field in phi SLs… #9319

Merged
merged 1 commit into from May 29, 2015

Conversation

namapane
Copy link
Contributor

… of wheels+-2 of MB1) when B=0
Same as #9314, but for 74X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_4_X.

Do not apply DT vdrift correction (that accounts for field in phi SLs

It involves the following packages:

RecoLocalMuon/DTRecHit

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 29, 2015

+1

for #9319 d138f91

  • jenkins test (not including 0T) pass OK and show no difference in comparisons with the baseline, as expected
  • tested locally on 100 events from run=200781 (0T, PU~30): there are minor changes starting from the DT segment distributions with decreasing impact in distributions downstream
    all_test9319-200781vsorig-200781_runminbias2011awf1000p0c_mindtchamberiddtrecsegment4dsownedrangemap_dt4dsegments__reco_obj_collection__data__chi2 99_99

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants