Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the MVAMET algorithm plus use of new training files #9333

Merged

Conversation

mmarionncern
Copy link

Update of the MVAMET algorithm + use of new training files :
The RECO/miniAOD sequence is untouched by the changes of the mva MET algorithm: no expected changes in term of performances/contents at the RECO level

Performances of the MVA met are better than with the previous version of the algorithm and the previous training.
Corresponding training files are updated in :
cms-data/RecoMET-METPUSubtraction#2

Test files have been updated as well.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_5_X.

Update of the MVAMET algorithm plus use of new training files

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Float_t numVertices_;

double dZcut_;
Float_t* createFloatVector(std::vector<std::string> variableNames);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use regular basic types, instead of root typedefs

@slava77
Copy link
Contributor

slava77 commented May 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 8, 2015

+1

For #9333 f5ce07b

Updating of the MET MVA algorithm. The Reco and Mini-AOD sequences are untouched by these changes. #9378 is the matching 74X version of this PR.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-06-06-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 12, 2015
…ing-30Jan15

Update of the MVAMET algorithm plus use of new training files
@cmsbuild cmsbuild merged commit 9f68ee0 into cms-sw:CMSSW_7_5_X Jun 12, 2015
@mmarionncern mmarionncern deleted the MVAMET-75X-from-72X-13TeV-Training-30Jan15 branch November 14, 2016 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants