Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in info message #9343

Merged
merged 1 commit into from May 30, 2015

Conversation

Dr15Jones
Copy link
Contributor

Fixed misspelling of View in message

Fixed misspelling of View in message
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 29, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Fix typo in info message

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 6b50162
I found errors in the following unit tests:

---> test dumpDDExpandedView had ERRORS
---> test testmat had ERRORS
---> test testDDCompactView had ERRORS
---> test dumpDDCompactView had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9343/5146/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c3a6214
9dfb003
dd1b6d7
4f215b0
173b973
1fa1c0b
7082c5c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9343/5146/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9343/5146/git-merge-result

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

the unit test failures are not related to this pull request (they are in the IB).

davidlange6 added a commit that referenced this pull request May 30, 2015
@davidlange6 davidlange6 merged commit 2bb975b into cms-sw:CMSSW_7_5_X May 30, 2015
@Dr15Jones Dr15Jones deleted the fixTypeInErrorMessage branch August 14, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants