Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Geant4 Physics Lists for exotics #9357

Merged
merged 1 commit into from Jun 2, 2015
Merged

Cleanup Geant4 Physics Lists for exotics #9357

merged 1 commit into from Jun 2, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented May 30, 2015

Several fixes and clean-up CustomPhysics sub-package:

  1. Fixed Physics Lists for exotics for the MT mode
  2. Fixed option (currently not used) to retrieve tables of cross sections from files
  3. Clean-up PHysicsLists for exotic particles
  4. Clean-up LogInfo printouts in CustomPhysics sub-package

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 30, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_5_X.

Cleanup Geant4 Physics Lists for exotics

It involves the following packages:

SimG4Core/Application
SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented May 30, 2015

please test

@civanch
Copy link
Contributor Author

civanch commented May 30, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9357/5180/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 2, 2015
@cmsbuild
Merge pull request #9357 from civanch/RHadronsPhysList
9490c8d 
Cleanup Geant4 Physics Lists for exotics
@cmsbuild cmsbuild merged commit 9490c8d into cms-sw:CMSSW_7_5_X Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@civanch @cmsbuild @davidlange6