Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/DetId: clean dictionary of duplicate selection rules #9370

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 31, 2015

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

Warning: Selection file classes_def.xml, lines 7 and 6. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "DetIdCollection" while the class is
"edm::EDCollection<DetId>".

Tested by comparing seal_cap.cc, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

    Warning: Selection file classes_def.xml, lines 7 and 6. Attempt to
    select with a named selection rule an already selected class. The name
    used in the selection is "DetIdCollection" while the class is
    "edm::EDCollection<DetId>".

Tested by comparing `seal_cap.cc`, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/DetId: clean dictionary of duplicate selection rules

It involves the following packages:

DataFormats/DetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented May 31, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants