Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Egamma HLT RelVal #9389

Merged
merged 1 commit into from Jun 10, 2015
Merged

Fix for Egamma HLT RelVal #9389

merged 1 commit into from Jun 10, 2015

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Jun 1, 2015

Fix for Egamma HLT RelVal. Previously, only the 'OR' keyword was known for L1 triggers. Now also 'Or' is recognised. Furthermore, in case that there is an OR of singleEG, doubleEG and tripleEG L1 triggers, the lowest number of candidates necessary is set now for the L1 filter.

…, doubleEG and tripleEG L1 triggers are OR-ed, use the lowest number of candidates necessary
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_7_5_X.

Fix for Egamma HLT RelVal

It involves the following packages:

HLTriggerOffline/Egamma

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

@thomreis
Copy link
Contributor Author

Hi, nothing happened for this PR for some time now. Could you have a look please so that it can be integrated?

@deguio
Copy link
Contributor

deguio commented Jun 10, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request?

@thomreis
Copy link
Contributor Author

Hi, sorry I was on holiday. There is currently no 74x version of this PR. This validation tool is usually not used for data. However, if it is easily possible the fix could also be used without modification for 74x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants