New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Egamma HLT RelVal #9389
Conversation
…, doubleEG and tripleEG L1 triggers are OR-ed, use the lowest number of candidates necessary
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_7_5_X. Fix for Egamma HLT RelVal It involves the following packages: HLTriggerOffline/Egamma @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Hi, nothing happened for this PR for some time now. Could you have a look please so that it can be integrated? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request? |
Hi, sorry I was on holiday. There is currently no 74x version of this PR. This validation tool is usually not used for data. However, if it is easily possible the fix could also be used without modification for 74x releases. |
Fix for Egamma HLT RelVal. Previously, only the 'OR' keyword was known for L1 triggers. Now also 'Or' is recognised. Furthermore, in case that there is an OR of singleEG, doubleEG and tripleEG L1 triggers, the lowest number of candidates necessary is set now for the L1 filter.