Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kCanRebin is replaced with SetCanExtend in online beamspot code for dqm #9416

Merged

Conversation

sushilchauhan
Copy link
Contributor

kCanRebin is replaced with SetCanExtend in online BeamSpot code for DQM to work properly in 74x

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

A new Pull Request was created by @sushilchauhan for CMSSW_7_4_X.

kCanRebin is replaced with SetCanExtend in online beamspot code for dqm

It involves the following packages:

DQM/BeamMonitor

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

+1
this one will be tested in the online DQM playback

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

@danduggan

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

@sushilchauhan
please submit to 75 as well otherwise the change is lost.
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9416/5290/summary.html

There are some workflows for which there are errors in the baseline:
50202.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild added a commit that referenced this pull request Jun 4, 2015
…pre5

replaced kCanRebin with SetCanExtend for beamspot code for online DQM as done in PR #9416
@davidlange6
Copy link
Contributor

+1

@wmtan
Copy link
Contributor

wmtan commented Jun 11, 2015

This PR should not have been merged into 7_4_ROOT5_X. It is ROOT6 specific. It breaks 7_4_ROOT5_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants