Customize HLT for new jet correctors #9426
Conversation
The new jet corrector mechanism must be used in order to complete the consumes migration. This change adds a new customize function to handle the conversion from the old jet correctors to the new ones.
Certain tools expect all elements on a Path to have a label defined. Attaching the newly created Sequences to the Process guarantees that those Sequences have a label.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. Customize HLT for new jet correctors It involves the following packages: HLTrigger/Configuration @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. |
|
please test |
|
I made sure that all tests from addOnTests.py still pass after this modification. |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
cmsbuild
added
comparison-pending
hlt-pending
and removed
comparison-pending
hlt-pending
orp-pending
pending-signatures
tests-started
labels
|
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log ----- Begin Fatal Exception 03-Jun-2015 18:29:51 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'digitisation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneRandom(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log ----- Begin Fatal Exception 03-Jun-2015 18:48:47 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'validation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
|
DAS still causing the tests to fail. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Customize HLT for new jet correctors
|
@Dr15Jones |
This is the last modification needed in order to have all standard workflows have their modules' call all the needed
consumes. This pull request replaces the old jet correctors which used a product from the EventSetup with the new jet correctors which use a product from the Event. This switch was already made in all non-HLT workflows.