RecoParticleFlow/PFTracking/interface/LightPFTrackProducer.h

[milosdjordjevic]

Migrating this "legacy" CMSSW module to "stream"

[cmsbuild]

A new Pull Request was created by @milosdjordjevic for CMSSW_7_5_X.

RecoParticleFlow/PFTracking/interface/LightPFTrackProducer.h

It involves the following packages:

RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 58c4d34
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/plugins/PFNuclearProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/plugins/GoodSeedProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/plugins/PFDisplacedVertexCandidateProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/plugins/PFV0Producer.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/plugins/LightPFTrackProducer.cc:2:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/interface/LightPFTrackProducer.h:13:61: error: expected class-name before '{' token
 class LightPFTrackProducer : public edm::stream::EDProducer {
                                                             ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/RecoParticleFlow/PFTracking/interface/LightPFTrackProducer.h:23:16: error: 'virtual void LightPFTrackProducer::beginRun(const edm::Run&, const edm::EventSetup&)' marked override, but does not override
   virtual void beginRun(const edm::Run&,const edm::EventSetup&) override ;
                ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9433/2681/summary.html

[cmsbuild]

-1
Tested at: a58bc9c
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 03-Jun-2015 17:50:51 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 03-Jun-2015 17:54:08 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9433/5259/summary.html

[slava77]

DAS/file access errors
😿

[slava77]

+1

for #9433 58c4d34

• changes in the code are as expected (change only in the inheritance of the EDProducer is sufficient here; thread unsafe elements are not used in the implementation)
• tested locally in CMSSW_7_5_X_2015-06-03-1100 /test area sign559/ in a regular run (not threaded). Tests pass and comparisons show no differences as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1