Bugfix in L1 GCT ET sums hardware emulator

[nsmith-]

Algorithm bug triggered an assertion.
Fix has been discussed with @mulhearn
This is identical to #9430, but applied to 75X

First observed in Run 245684, Event 1063307554, LumiSection 476.
To reproduce, need to change the region sums source in L1Trigger/L1TCalorimeter/test/SimL1Emulator_Stage1.py to the hardware values rather than reproducing from RAW. This is due to the particular run setup for that run.

from L1Trigger.L1TCalorimeter.simRctUpgradeFormatDigis_cfi import *
simRctUpgradeFormatDigis.regionTag = cms.InputTag("gctDigis")
simRctUpgradeFormatDigis.emTag = cms.InputTag("gctDigis")

The event can be found at /afs/cern.ch/user/z/zhangj/public/Splashes_Run245684_1_2_IKY.root
The output was

/home/l1tlocal/CMSSW_7_4_2/src/L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2EtSumAlgorithmImpHW.cc:245:
std::tuple<int, int, int> l1t::Stage1Layer2EtSumAlgorithmImpHW::doSumAndMET(const std::vector<l1t::Stage1Layer2EtSumAlgorithmImpHW::SimpleRegion>&, l1t::Stage1Layer2EtSumAlgorithmImpHW::ETSumType): 
Assertion `metPhi >=0 && metPhi < 18' failed.

[cmsbuild]

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_7_5_X.

Bugfix in L1 GCT ET sums hardware emulator

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mulhearn]

please test

[mulhearn]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9437/5517/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1