Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HI EP and DQM update #9440

Merged
merged 8 commits into from Jun 9, 2015
Merged

HI EP and DQM update #9440

merged 8 commits into from Jun 9, 2015

Conversation

BetterWang
Copy link
Contributor

Heavy Ion Event plane code update, (protection, bug fix).
DQM update for new event plane list.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

HI EP and DQM update

It involves the following packages:

DQM/Physics
HLTrigger/HLTanalyzers
RecoHI/HiEvtPlaneAlgos

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rappoccio, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Since data taking (and corresponding validation) is actually done with 74X, does it exist (or do you foresee) a 74X counterpart of this pull request?

@BetterWang
Copy link
Contributor Author

Hi @perrotta , There is a back port #9382 of this fix and PR #9022.
My understanding would be the heavy ion data taking release will be 75X. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants