Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prescale index and L1 tables with per-type data to 75X #9441

Merged

Conversation

avetisya
Copy link
Contributor

@avetisya avetisya commented Jun 4, 2015

Forward porting #9301 to CMSSW_7_5_X. This adds the prescale index and L1 trigger tables split by event type.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @avetisya for CMSSW_7_5_X.

Adding prescale index and L1 tables with per-type data to 75X

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

-1
Tested at: 99726de
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/FWCore/Version/src/GetFileFormatVersion.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/FWCore/Version/src/GetReleaseVersion.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/HLTrigger/JSONMonitoring/plugins/SealModule.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/HLTrigger/JSONMonitoring/plugins/TriggerJSONMonitoring.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/HLTrigger/JSONMonitoring/plugins/TriggerJSONMonitoring.cc: In member function 'virtual void TriggerJSONMonitoring::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-03-1100/src/HLTrigger/JSONMonitoring/plugins/TriggerJSONMonitoring.cc:135:31: error: 'class HLTConfigProvider' has no member named 'prescaleSet'
   prescaleIndex_ = hltConfig_.prescaleSet(iEvent, iSetup);
                               ^
gmake: **\* [tmp/slc6_amd64_gcc491/src/HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoringPlugins/TriggerJSONMonitoring.o] Error 1
>> Building shared library tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so
Copying tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so to productstore area:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9441/10019/summary.html

@Martin-Grunewald
Copy link
Contributor

@avetisya
Right, there was a consumes-required migration in 75X, pull request #9055 #9055 - just check there how other clients had to change...eg, the HLTEventAnalyzerAOD plugin.

@Martin-Grunewald
Copy link
Contributor

@avetisya
Any progress on this issue?

@avetisya
Copy link
Contributor Author

Hi Martin,

Sorry, I was busy with on-call work and it's not easy to fully test this since every menu I've tried it with crashes for unrelated reasons. This version should work though.

-- Aram

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants