Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PileupJetIdAlgo from DQM/PhysicsHWW (forward port to 75x) #9450

Merged
merged 2 commits into from Jun 8, 2015

Conversation

dmitrijus
Copy link
Contributor

(forward port of #9350)

This removes all code and configuration which
originally was duplicated from RecoJets. Now the RecoJets code and
configuration is used for DQM/PhysicsHWW.

Please remove or tell me how to do it (I have no idea)
DQM/PhysicsHWW/data/mva_JetID_v1.weights.xml
from cms-data.

Dmitrijus Bugelskis added 2 commits June 4, 2015 15:04
... and use the proper one from RecoJets/JetProducers.

(cherry picked from commit 2006dcc)
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X.

Remove PileupJetIdAlgo from DQM/PhysicsHWW (forward port to 75x)

It involves the following packages:

DQM/PhysicsHWW

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

@deguio
Copy link
Contributor

deguio commented Jun 5, 2015

@davidlange6
in several cases recent report by cmsbuild are not available. do you know the reason?
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Jun 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@Degano - could you help with the needed change to cms-data?

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants