Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safe conversion for HLT modules in CommonTools/RecoAlgos, backport of #9081 #9478

Merged
merged 1 commit into from Jun 16, 2015

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Jun 5, 2015

HLT modules LargestEtCaloJetSelector, LargestEtPFJetSelector, and RecoTrackRefSelector in CommonTools/RecoAlgos migrated to be thread safe. This PR is a backport of #9081, which was merged and has been in 75X since CMSSW_7_5_X_2015-05-25-1100. It was created in response to a request from Andrea Bocci: https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1353.html

This change should have no effect on monitored quantities.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for CMSSW_7_4_X.

Thread-safe conversion for HLT modules in CommonTools/RecoAlgos, backport of #9081

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Jun 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

@slava77
Copy link
Contributor

slava77 commented Jun 7, 2015

+1

for #9478 56c1406

  • the same code change was integrated in 75X (available in pre5)
  • jenkins tests pass and comparisons with baseline show no differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants