Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFormats/Math: remove unused selection rules #9505

Merged
merged 1 commit into from Jun 8, 2015
Merged

DataFormats/Math: remove unused selection rules #9505

merged 1 commit into from Jun 8, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 8, 2015

ROOT::Math::Polar3D<*> is not available in the translation unit, thus
there is nothing to select into dictionary.

Tested on ROOT5 and ROOT6. Removing does not modify the types in
dictionary.

Resolves:

Warning - unused class rule: ROOT::Math::Polar3D<*>

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

DataFormats/Math: remove unused selection rules
8f1b491 
`ROOT::Math::Polar3D<*>` is not available in the translation unit, thus
there is nothing to select into dictionary.

Tested on ROOT5 and ROOT6. Removing does not modify that types in
dictionary.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@davidlt davidlt mentioned this pull request Jun 8, 2015
Closed
31 tasks
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/Math: remove unused selection rules

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

+1
Tested at: 8f1b491
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9505/10121/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a9f988
d78a36b
ab71347
4ef6d59
1d937ec
8fde817
ff163e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9505/10121/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9505/10121/git-merge-result

davidlange6 added a commit that referenced this pull request Jun 8, 2015
@davidlange6
Merge pull request #9505 from davidlt/clean-unused-select-rules-DataF…
30b1a11 
…ormats-Math

DataFormats/Math: remove unused selection rules
@davidlange6 davidlange6 merged commit 30b1a11 into cms-sw:CMSSW_7_5_X Jun 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9505/10121/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending orp-pending pending-signatures reconstruction-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @davidlange6