Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for the iov sequence iterators as delivered by the caching in pages #9661

Merged
merged 1 commit into from Jun 18, 2015
Merged

fix for the iov sequence iterators as delivered by the caching in pages #9661

merged 1 commit into from Jun 18, 2015

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Jun 17, 2015

This PR contains a fix for the iterator of the iov sequence. The till value is set to the upper bound of the cache when the iteration reaches the end of the page.

@ggovi
Copy link
Contributor Author

ggovi commented Jun 17, 2015

+1

@ggovi
Copy link
Contributor Author

ggovi commented Jun 17, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 17, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: e6d636f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9661/8235/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9661/8235/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 18, 2015
@cmsbuild
Merge pull request #9661 from ggovi/new-conddb-fix-iov-caching-1
43b3132 
fix for the iov sequence iterators as delivered by the caching in pages
@cmsbuild cmsbuild merged commit 43b3132 into cms-sw:CMSSW_7_5_X Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggovi @cmsbuild @davidlange6