Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hierarchy constraints as default in Millepede #9750

Merged

Conversation

cmsbuild
Copy link
Contributor

This sets back the default way constraints are treated in Millepede to using hierarchy constraints, and reverts the temporary changes introduced with #6254. Previous problems were found to be due to numerical effects in pede. These are solved in >=rev137, which uses 'elimination' instead of lagrangian multipliers.
Automatically ported from CMSSW_7_5_X #9713 (original by @mschrode).

Previous problems were found to be due to numerical effects in
pede. These are solved in >=rev137, which uses 'elimination'
instead of lagrangian multipliers.
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_6_X.

Set hierarchy constraints as default in Millepede

It involves the following packages:

Alignment/CommonAlignmentAlgorithm

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2015

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jul 9, 2015

@diguida
Copy link
Contributor

diguida commented Dec 16, 2015

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10322/console

@diguida
Copy link
Contributor

diguida commented Dec 16, 2015

76X is ok, as there we have the new Pede version.

@cmsbuild
Copy link
Contributor Author

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2015

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor Author

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 5, 2016
Set hierarchy constraints as default in Millepede
@cmsbuild cmsbuild merged commit 7887819 into cms-sw:CMSSW_7_6_X Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants