Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in convertToUnscheduled with decorators #9989

Conversation

Dr15Jones
Copy link
Contributor

When rebuilding a path in convertToUnscheduled, any decorator applied to a module, e.g. '~', were previously stripped away.

When rebuilding a path in convertToUnscheduled, any decorator applied to a module, e.g. '~', were previously stripped away.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Fix bug in convertToUnscheduled with decorators

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

I only tested this by hand in 7_6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

@davidlange6 did you run the tests to be sure the change worked in 7_4?

@davidlange6
Copy link
Contributor

they are running.. will work in parallel.. and also test myself

On Jul 1, 2015, at 5:14 PM, Chris Jones notifications@github.com wrote:

@davidlange6 did you run the tests to be sure the change worked in 7_4?


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

@Dr15Jones Dr15Jones deleted the fixModuleDecoratorWithConvertToUnscheduled_7_4 branch August 14, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants