Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "usedFallback" boolean from (pre|post)OpenFile signals #331

Closed
makortel opened this issue Dec 6, 2021 · 1 comment
Closed

Remove "usedFallback" boolean from (pre|post)OpenFile signals #331

makortel opened this issue Dec 6, 2021 · 1 comment

Comments

@makortel
Copy link
Collaborator

makortel commented Dec 6, 2021

After cms-sw/cmssw#35505 the "useFallback" information is not available yet for preOpenFile signal, and delivering it via postOpenFile signal would be a bit cumbersome. Currently this boolean is used only by Tracer in (pre|post)OpenFile.

After cms-sw/cmssw#35505 Tracer is also the only user of the boolean in (pre|post)CloseFile signals ( StatisticsSenderService gets it by other means), so we could consider removing the boolean also from those signals (if not deemed useful in Tracer).

Done in cms-sw/cmssw#36400

@makortel
Copy link
Collaborator Author

makortel commented Dec 6, 2021

We agreed that Tracer doesn't really need this information, so we could just remove this boolean also for (pre|post)CloseFile signals.

@makortel makortel added the Task label Dec 7, 2021
@makortel makortel closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant