Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate feasibility of streamer file/data format based fix #879

Closed
Tracked by #873
makortel opened this issue Apr 10, 2024 · 4 comments
Closed
Tracked by #873

Investigate feasibility of streamer file/data format based fix #879

makortel opened this issue Apr 10, 2024 · 4 comments
Assignees
Labels

Comments

@makortel
Copy link
Collaborator

makortel commented Apr 10, 2024

Conceptual ideas were listed in cms-sw/cmssw#44643 (comment)

@makortel
Copy link
Collaborator Author

Currently working on a more concrete plan of option 2

@makortel makortel added the Task label Apr 10, 2024
@makortel
Copy link
Collaborator Author

Latest comments in the issue suggest going with option 1 instead

@makortel
Copy link
Collaborator Author

makortel commented Apr 16, 2024

Design session on option 1

  • Easy way: Source would issue a file transition when it encounters a "SendProcess" section in the concatenated streamer file that differers from the previous "SendProcess" section
    • Or only when it encounters a new "SendProcess"?
      • In this case the Source would have to tell BranchIDListsHelper what to do when the "SendProcess" differs from the previous one
  • Plan
    • Add new section "SendProcess" (need better name)
      • Need to change streamer writer and reader
      • But don't use them yet at this stage (i.e. content is dummy)
    • "SendProcess" (either file or data format) would contain the checksum of the corresponding InitMessage, and do sanity check early
    • Source monitors changes in the "SendProcess" content (checksum), and initiates a file transition when "SendProcess" differs from the previous
    • Move the BranchIDLists from SendJob to "SendProcess"
    • Try to avoid file transitions when "SendProcess" differs from previous, but has been seen before in the process
    • Try to avoid file transitions altogether

@makortel
Copy link
Collaborator Author

I formalized the plan to #873, and consider this investigation task complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants