Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments regarding edm::Handle in TauFunc in PR https://github.com/cms-sw/cmssw/pull/31744 #143

Conversation

lwezenbe
Copy link

PR description

  • Change TauFunc to take const vector* instead of edm::Handle
  • Remove LightLepFunc
  • Initialize electron and muon collections using Event::get(token_)

PR validation

  • Code and format checks passed
  • RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD.py was run with a setup without any changes and the version of the setup in this PR over the same 1000 events of the same dataset. The output of both runs was identical.
  • A simple setup was made with hltGetConfiguration for the latest HLT menu where the isolation modules were replaced by the adapted DeepTauId module. This setup ran smoothly and the output looked as expected. Output of this setup was checked before and after making the changes and was identical

@swozniewski swozniewski merged commit f14d756 into cms-tau-pog:CMSSW_11_2_X_tau-pog_deepTauForAODandHLT Oct 30, 2020
swozniewski pushed a commit that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants