Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic BOOL seem to return 0x01 rather than 0xff. #30

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Atomic BOOL seem to return 0x01 rather than 0xff. #30

merged 1 commit into from
Sep 11, 2018

Conversation

pfumagalli
Copy link
Contributor

Description, Motivation, and Context

This simply changes the way BOOL are checked when parsed atomically

How Has This Been Tested?

Yes, locally on a Logix5572 (Firmware 31.011)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

See issue #29

@coveralls
Copy link

Pull Request Test Coverage Report for Build 92

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 51.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tag/index.js 0 1 0.0%
Totals Coverage Status
Change from base Build 85: 0.08%
Covered Lines: 472
Relevant Lines: 882

💛 - Coveralls

@cmseaton42 cmseaton42 added the bug fix Addresses Known Bug label Sep 10, 2018
@jhenson29
Copy link
Collaborator

@cmseaton42 I tested this on v20 and v31. Should be okay. You can see my other comment on how we got here in issue #29.

Version increment to 1.2.1?

@cmseaton42 cmseaton42 merged commit 9446a36 into cmseaton42:master Sep 11, 2018
@cmseaton42
Copy link
Owner

@pfumagalli Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Addresses Known Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants