Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #37

Merged
merged 1 commit into from
Sep 30, 2018
Merged

bugfix #37

merged 1 commit into from
Sep 30, 2018

Conversation

jhenson29
Copy link
Collaborator

Tag.unstageWriteRequest had an incorrect reference to Tag.state.tag.controllerValue

Description, Motivation, and Context

Incorrect referenced caused tag.value to be undefined in some cases. (If the same value was written to the PLC two times in a row).

How Has This Been Tested?

Tested with writes to PLC.

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

Fixes #36

@jhenson29 jhenson29 added the bug fix Addresses Known Bug label Sep 30, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 108

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 50.982%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tag/index.js 0 3 0.0%
Totals Coverage Status
Change from base Build 107: -0.04%
Covered Lines: 472
Relevant Lines: 883

💛 - Coveralls

@cmseaton42
Copy link
Owner

Awesome, thanks for the fix! I'll pull this when I'm back in front of my computer today :)

@cmseaton42 cmseaton42 merged commit 6c1ccb1 into cmseaton42:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Addresses Known Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag.value is undefined after writing to PLC
3 participants