Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add configuration option to unconnected send timeout #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gfcittolin
Copy link

Description, Motivation, and Context

Implements changes as discussed in #67 to allow custom-setting the value of timeout on unconnected send messages

How Has This Been Tested?

Tested with SoftLogix

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

@coveralls
Copy link

Pull Request Test Coverage Report for Build 148

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 51.102%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controller/index.js 1 2 50.0%
Totals Coverage Status
Change from base Build 141: 0.08%
Covered Lines: 473
Relevant Lines: 884

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants