Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchable fatal errors are handled inconsistently #278

Closed
cmb69 opened this issue Aug 12, 2017 · 1 comment
Closed

Catchable fatal errors are handled inconsistently #278

cmb69 opened this issue Aug 12, 2017 · 1 comment
Labels
bug
Milestone

Comments

@cmb69
Copy link
Member

@cmb69 cmb69 commented Aug 12, 2017

The handling of catchable fatal errors (E_RECOVERABLE_ERROR) completely depends on debug mode. If it is enabled, the error is reported as debug message (Unknown error type: …,), but the script continues; if it is disabled the error terminates the script.

@cmb69 cmb69 added the bug label Aug 12, 2017
@cmb69 cmb69 added this to the 1.7.1 milestone Aug 12, 2017
cmb69 added a commit to cmb69/cmsimple-xh that referenced this issue Aug 30, 2017
We are not convinced that ignoring recoverable (formerly called
catchable) errors (`E_RECOVERABLE_ERROR`) is a good idea, generally.
Furthermore, to do so would require a general error handler (opposed to
our long standing debug mode handler). Therefore we decide to treat
recoverable errors just like user errors (E_USER_ERROR), i.e. to bail
out whenever they occur.

We changing the call to `die()` to `XH_exit()` to be able to mock the
function in a respective test.
@cmb69

This comment has been minimized.

Copy link
Member Author

@cmb69 cmb69 commented Aug 30, 2017

I suggest to merge PR #287.

@cmb69 cmb69 closed this in 9e97b82 Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.