Close #182: Separate page names from the content #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change $cf[headings][show] to false, and hard-code this in the code, so that we can remove this config option. This makes $cf[headings] [format] unused, so we remove it as well. We also can get rid of the page data fields 'heading' and 'show_heading', as the heading of the page is independent of the page name now.
The whole point of this branch is to get rid of $cf['headings'], but oviously we have forgotten to actually remove these config variables.
We accidentally changed the default of `$cf['mode']['advanced']`, so we revert that hereby.
We missed to remove the global "declarations", after we had removed the respective variables.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change $cf[headings][show] to false, and hard-code this in the code,
so that we can remove this config option. This makes $cf[headings]
[format] unused, so we remove it as well. We also can get rid of the
page data fields 'heading' and 'show_heading', as the heading of the
page is independent of the page name now.