New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vending tgui #1075
Vending tgui #1075
Conversation
This is really awesome good work man |
Resolved this - problem was that I made the suggested change which put all the to_chats etc in the access logic and when the UI_State came back it flagged that you didn't have access without your access card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Fix/Feature pull request is currently below zero (-4). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
Yeah this UI isn't good at all, it somehow makes lag worse every time you open, scroll or vend an item. Was this even tested? |
About The Pull Request
Vendor Sorted nano to tgui
PR migrates
/obj/structure/machinery/cm_vending/sorted
vending machines from nano to tgui.The vendor UI respects:
A noticebox popup is displayed when the items are hovered over, the items description is displayed.
The bulk of the data is statically generated, improving performance on ui refresh.
A search bar is provided at the top of the UI, it live filters the items.
Item icons are generated and displayed in the vendor UI.
There are no gameplay changes, this is purely a UI change.
USCM template
A basic UI scss has been added for USCM. It is rudimentary, sporting a background image. There is a lot of scope to improve on this but is still worth adding.
Why It's Good For The Game
This upgrades the UI from nano to tgui. It is a much more user friendly experience, making it easier to access many of the items the USCM use.
Changelog
🆑
add: TGUI interface for many cm custom vendors
qol: Search bar for item search for vendors
qol: Item description appears as popup in vendor UI
qol: Item icons are displayed in vendor UI
/:cl: