Adjusts Marine Paygrades for Playercounts above 120 #2807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get feedback from someone on the dev team regarding this? |
harryob
requested changes
Mar 10, 2023
if you want your code reviewing, mark it as ready for review please, otherwise i'll skip over them |
|
Sorry, You got it. |
Co-authored-by: harryob <me@harryob.live>
Kitsunemitsu
force-pushed
the
highpop-ranks
branch
from
76957b7
to
7fcb58a
Compare
harryob
requested changes
Mar 12, 2023
Co-authored-by: harryob <me@harryob.live>
Zonespace27
requested changes
Mar 14, 2023
Zonespace27
requested changes
Mar 14, 2023
|
Do I need to wait for any more reviews or is this ready for merge? |
morrowwolf
suggested changes
Mar 18, 2023
There was a problem hiding this comment.
OK so I'm still mulling this one over in my head which is why the DNM tag is still on. For now, and this is not guarantee this is going to get merged and I may change my mind and go back, let's do the following:
Bronze medal gets CPL for only spec/SG at 120+ rather than gold for engi/medic/spec/SG.
Drop the LCPL riflemen.
morrowwolf
suggested changes
Mar 19, 2023
morrowwolf
suggested changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This increases the ranks of the following roles at highpop (120 Players):
SL - Always set to SSGT
RTO - Always set to SGT
Engi, Medic, Spec, SG - Set to LCPL, If they have a gold medal they're a CPL.
They're specialists, after all!
Marines - if they have 175 hours and there's more than 120 players, they have access to LCPL, as high as low-playtime ""trained"" role
Todo: Check playercount at roundstart, rather than when ranks are chosen, so that ranks don't increase as time goes on. I was going to put this in an initialization subsystem, but I couldn't find any good one. Please direct me to where I can put the check code.
Explain why it's good for the game
Kinda strange how one Sergeant is in charge is in charge of 15-20 people, in the army it's usually 4-12.
This remedies that.
Ive seen squads as large as 30+ and still manned by a Sergeant.
Testing Photographs and Procedure
For obvious reasons (I do not have 120 players to get on my test server) I cannot test this, but will try to bruteforce some tests on a local, If I am specifically asked to.
Changelog
馃啈
add: Marine paygrades increase for playercounts above 120.
/:cl: