Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive Lesser Drone and Facehugger temporary communication restrictions #5688

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 9, 2024

About the pull request

This PR revives and expands #5352. By expand I mean that in addition to a 3 minute restriction for say and hivemind speak, custom emotes and pointing are also restricted during the 3 minute window. Past that I did some additional refactoring.

Explain why it's good for the game

As a ghost role, this acts as a measure to mechanically limit the communication of meta info to other members in the hive. For now the restriction is only 3 minutes.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

馃啈 Zonespace Drathek
balance: Lesser drones and Facehuggers cannot speak, custom emote, or point for 3 minutes after spawning
/:cl:

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 9, 2024
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 9, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually one thing,

code/datums/components/temporary_mute.dm Outdated Show resolved Hide resolved
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@harryob harryob added this pull request to the merge queue Feb 13, 2024
Merged via the queue into cmss13-devs:master with commit f0251fe Feb 13, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 13, 2024
@Drulikar Drulikar deleted the Revive_Ghost_Say branch February 14, 2024 00:23
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2024
# About the pull request

This PR is a followup to #5688 to additionally prevent death messages
getting sent to the hive during the temporary mute time.

# Explain why it's good for the game

Ultimately this is to quell more concerns with ghosts using meta
knowledge of say a flank approaching and throwing themselves at that
flank and informing the hive of the flank via their death message
location.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/76988376/8b8426bd-8f82-43f6-bb70-a91346c47534

</details>


# Changelog
:cl: Drathek
del: Removed death messages for lesser drones and facehuggers that are
still temporarily muted
/:cl:
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
# About the pull request

This PR is a follow up to #5688 correcting the end message for
facehuggers.

# Explain why it's good for the game

Fixes #5756 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: Drathek
spellcheck: Reworded message when a facehugger's temporary mute ends to
not mention hivemind
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants