WP in Jet::IsTagged and FatJet::IsTagged

[bhoh]

Btagging WPs are hard coded in Jet.C and FatJet.C.
But these are valid only for 2017.
I think it has a potential to cause a mistake.
How about removing "IsTagged" method?
or changing like this?

bool Jet::IsTagged(Tagger tg, double wp){
  double tr = GetTaggerResult(tg);
  return (tr>wp);
}

or should we think more clever way?

(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180)
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/FatJet.C#L140-L194)

[jedori0228]

You can update

SKFlatAnalyzer/data/Run2Legacy_v1/2017/BTag/taggermap.txt

Lines 1 to 10 in 3d54d9a

	### taken frmo https://twiki.cern.ch/twiki/bin/viewauth/CMS/BtagRecommendation94X on 29 Jan 2019
	2017 CSVv2 Loose 0.5803
	2017 CSVv2 Medium 0.8838
	2017 CSVv2 Tight 0.9693
	2017 DeepCSV Loose 0.1522
	2017 DeepCSV Medium 0.4941
	2017 DeepCSV Tight 0.8001
	2017 DeepFlavour Loose 0.0521
	2017 DeepFlavour Medium 0.3033
	2017 DeepFlavour Tight 0.7489

and try to use BTagSFUtil I think..?

[jalmond]

These files should be up to date, if not you should update the values/taggers and make a PR.

To use it in your code, you can follow the recipe in Example run.

https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L48

https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L336

Maybe the function in Jet class can be removed tio avoid confusion.

[bhoh]

Jet::IsTagged is used once in https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/SKFlatValidation.C#L161.
It's okay to use for 2017, but it returns wrong result for other than 2017.
After changing that part like ExampleRun.C, we can remove Jet::IsTagged and FatJet::IsTagged.
If you guys agree with that idea, I could make a pull request.

(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180)
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/FatJet.C#L140-L194)

[jalmond]

I think this is ok to make the pull request.

[jedori0228]

Please check #37

[bhoh]

Please check #37

it looks good!

[jedori0228]

#37 merged.