-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP in Jet::IsTagged and FatJet::IsTagged #33
Comments
You can update SKFlatAnalyzer/data/Run2Legacy_v1/2017/BTag/taggermap.txt Lines 1 to 10 in 3d54d9a
|
These files should be up to date, if not you should update the values/taggers and make a PR. To use it in your code, you can follow the recipe in Example run. https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L48 https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/ExampleRun.C#L336 Maybe the function in Jet class can be removed tio avoid confusion. |
Jet::IsTagged is used once in https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/Analyzers/src/SKFlatValidation.C#L161. (https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180) |
I think this is ok to make the pull request. |
Please check #37 |
it looks good! |
#37 merged. |
Btagging WPs are hard coded in Jet.C and FatJet.C.
But these are valid only for 2017.
I think it has a potential to cause a mistake.
How about removing "IsTagged" method?
or changing like this?
or should we think more clever way?
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/Jet.C#L126-L180)
(https://github.com/CMSSNU/SKFlatAnalyzer/blob/master/DataFormats/src/FatJet.C#L140-L194)
The text was updated successfully, but these errors were encountered: