Skip to content

Commit

Permalink
Update NEWS.md, add cran-comments.md
Browse files Browse the repository at this point in the history
  • Loading branch information
kloppen committed May 7, 2024
1 parent b6a8fe3 commit f7bc30f
Show file tree
Hide file tree
Showing 4 changed files with 63 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@
^vignettes/articles$
^logo.svg$
^data-raw$
^tests/_snaps/*
^tests/_snaps/*
^cran-comments.md$
^CRAN-SUBMISSION$
3 changes: 3 additions & 0 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Version: 0.4.0
Date: 2024-05-06 13:34:25 UTC
SHA: bcc13a7d1155d18d01fa58e50fd7df8d44aab04c
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Version 0.4.0
- First release on CRAN
- Minor documentation improvements

# Version 0.3.0
- Added functions for creating average stress-strain curves
(`average_curve_lm` and `average_curve_optim`)
Expand Down
53 changes: 53 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
Re-submission of package `cmstatrExt` to address CRAN comments on submission
made 06-May-2024.

## Test environments
- win-builder (`devel`, `release`, `oldrelease`)
- local Ubuntu 22.04, R 4.4.0
- GitHub Action runners:
- MacOS, R `release`
- Windows, R `release`
- Ubuntu, R `devel`
- Ubuntu, R `release`
- Ubuntu, R `oldrel`

## R CMD check results
There were no `ERRORs` or `WARNINGs`.

There was one expected `NOTE` on win-builder due to this being a new submission.

When built on Ubuntu, there is a `NOTE` related to the `libs` directory being
over 1 MB. I understand this to be a common `NOTE` for packages using `Rcpp`.

## Downstream dependencies
There are no downstream dependencies.

## Response to Initial Submission (2024-06-06)


>> Please add \value to .Rd files regarding exported methods and explain
>> the functions results in the documentation. Please write about the
>> structure of the output (class) and also what the output means. (If a
>> function does not return a value, please document that too, e.g.
>> \value{No return value, called for side effects} or similar)
>> Missing Rd-tags:
>> power_sim_dual.Rd: \value
The \value tag was added to power_sim_dual.Rd. No other instances of missing
\value tag were found.

>> \dontrun{} should only be used if the example really cannot be executed
>> (e.g. because of missing additional software, missing API keys, ...) by
>> the user. That's why wrapping examples in \dontrun{} adds the comment
>> ("# Not run:") as a warning for the user. Does not seem necessary.
>> Please replace \dontrun with \donttest.
>> Please unwrap the examples if they are executable in < 5 sec, or replace
>> dontrun{} with \donttest{}.
>> Please wrap examples that need packages in ‘Suggests’ in
>> if(requireNamespace("pkgname")){} instead.
>> -> iso_equiv_two_sample.Rd
\dontrun replaced with \donttest since this example takes ~30 seconds to run
on my PC. The example wrapped in `if(requireNamespace("tidyverse")){}`

>> Please fix and resubmit.

0 comments on commit f7bc30f

Please sign in to comment.