Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 94 - fixes bad logic in Worker.isRetryable #95

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Issue 94 - fixes bad logic in Worker.isRetryable #95

merged 3 commits into from
Dec 22, 2021

Conversation

timveil
Copy link
Collaborator

@timveil timveil commented Dec 22, 2021

this PR fixes bad logic in Worker.isRetryable where the method returned true when sqlState was null.

@timveil timveil linked an issue Dec 22, 2021 that may be closed by this pull request
isRetryable incorrectly returns true if sqlstate is null #94
Closed
@timveil timveil merged commit 5693ace into cmu-db:main Dec 22, 2021
@timveil timveil deleted the issue-94 branch December 22, 2021 21:01
@timveil timveil mentioned this pull request Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isRetryable incorrectly returns true if sqlstate is null
1 participant
@timveil