Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Wrong functionality exposed in DiskManagerUnlimitedMemory::EnableLatencySimulator #689

Open
4ever-xxxl opened this issue Jan 27, 2024 · 0 comments

Comments

@4ever-xxxl
Copy link

  void EnableLatencySimulator(bool enabled) { latency_simulator_enabled_ = enabled; }

The function should only allow false values ​​to be set to true, and should be judged externally. Otherwise we can call this function to cancel the delay to cheat in Project 1 LeaderBoard(2023 fall). Here is an example:

        auto *disk_manager_memory = dynamic_cast<DiskManagerUnlimitedMemory *>(disk_manager_);
        if (disk_manager_memory != nullptr) {
          disk_manager_memory->EnableLatencySimulator(false);
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant