Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): support count(*) #416

Merged
merged 4 commits into from Oct 6, 2022
Merged

feat(planner): support count(*) #416

merged 4 commits into from Oct 6, 2022

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 3, 2022

close #415

This is done by rewriting count(*) to count(1).

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from yliang412 October 3, 2022 20:38
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh merged commit f330e8d into master Oct 6, 2022
@skyzh skyzh deleted the skyzh/support-count-star branch October 6, 2022 14:30
qiuyu21 pushed a commit to qiuyu21/bustub that referenced this pull request Oct 15, 2022
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expr: support count(*)
2 participants