Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2): fix wrong definition of function #701

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(p2): fix wrong definition of function #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9fb59
fix(p2): fix wrong definition of function
Mar 6, 2024
109568f
Merge branch 'master' into functionfix
hnkjdaxzzq May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/include/storage/page/extendible_htable_header_page.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ExtendibleHTableHeaderPage {
* @param directory_idx index in the directory page id array
* @return directory page_id at index
*/
auto GetDirectoryPageId(uint32_t directory_idx) const -> uint32_t;
auto GetDirectoryPageId(uint32_t directory_idx) const -> page_id_t;

/**
* @brief Set the directory page id at an index
Expand Down
3 changes: 2 additions & 1 deletion src/storage/page/extendible_htable_header_page.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include "storage/page/extendible_htable_header_page.h"

#include "common/config.h"
#include "common/exception.h"

namespace bustub {
Expand All @@ -22,7 +23,7 @@ void ExtendibleHTableHeaderPage::Init(uint32_t max_depth) {

auto ExtendibleHTableHeaderPage::HashToDirectoryIndex(uint32_t hash) const -> uint32_t { return 0; }

auto ExtendibleHTableHeaderPage::GetDirectoryPageId(uint32_t directory_idx) const -> uint32_t { return 0; }
auto ExtendibleHTableHeaderPage::GetDirectoryPageId(uint32_t directory_idx) const -> page_id_t { return 0; }

void ExtendibleHTableHeaderPage::SetDirectoryPageId(uint32_t directory_idx, page_id_t directory_page_id) {
throw NotImplementedException("ExtendibleHTableHeaderPage is not implemented");
Expand Down